Skip to content

Add extra Chinese fonts #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2020
Merged

Add extra Chinese fonts #115

merged 1 commit into from
Jan 24, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 20, 2020

There is a really long research about this at readthedocs/readthedocs.org#6319 and there is not a perfect solution.

Although, the last comments propose the simpler and most approximated solution for this --which is adding some extra fonts to the build image.

@humitos humitos requested a review from a team January 20, 2020 09:21
ericholscher
ericholscher approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's annoying to have to manage this, but if it helps folks, I'm 👍 on it.

@humitos humitos merged commit 58f45f7 into master Jan 24, 2020
@humitos humitos deleted the humitos/chinese-fonts branch January 24, 2020 22:23
@humitos
Copy link
Member Author

humitos commented Jan 24, 2020

This will be available in the next release of our docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @ericholscher